Support NeoForge's ModDevGradle #72
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
My next step was to look at fixing the depreciation warnings in Gradle, but maybe I should do GH actions first :D. |
|
Any contributions would be very appreciated 🙏 We haven't really had a maintainer of this project for the last year, it could really use some love. |
|
Thanks! |
|
np. Will try to get a release out some time tomorrow, I want to update deps to fix deprecation warnings for people but I'm not super familiar with gradle plugin development |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #67.
This doesn't add support for version detection within those plugins. I wonder if it's worth moving the code that sniffs properties after the Loom/Paperweight version detection and, and always using that if a version cannot be found, rather than just doing that for NG/FG.